Skip to content

Remove deprecated generator data #7664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 10, 2025
Merged

Remove deprecated generator data #7664

merged 6 commits into from
Feb 10, 2025

Conversation

williambdean
Copy link
Contributor

@williambdean williambdean commented Jan 29, 2025 •
edited by github-actions bot
Loading

Description

Removing the support for generator data

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7664.org.readthedocs.build/en/7664/

@williambdean williambdean marked this pull request as draft January 29, 2025 13:04
@ricardoV94 ricardoV94 added maintenance major Include in major changes release notes section labels Jan 29, 2025
@ricardoV94
Copy link
Member

Still being imported somewhere from the failing tests

@ricardoV94 ricardoV94 changed the title Fully deprecated generator data Remove deprecated generator data Jan 29, 2025
@nataziel
Copy link
Contributor

nataziel commented Feb 5, 2025

The failing ubuntu test is just a flaky one, probably only need to worry about the other tests

@ricardoV94
Copy link
Member

The failing ubuntu test is just a flaky one, probably only need to worry about the other tests

Opened issue at #7674

@williambdean williambdean marked this pull request as ready for review February 8, 2025 11:21
@codecov
Copy link

codecov bot commented Feb 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.65%. Comparing base (d7d2be2) to head (85b3af5).
Report is 65 commits behind head on main.

Files with missing lines Patch % Lines
pymc/pytensorf.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7664      +/-   ##
==========================================
- Coverage   92.70%   92.65%   -0.05%     
==========================================
  Files         107      107              
  Lines       18391    18324      -67     
==========================================
- Hits        17050    16979      -71     
- Misses       1341     1345       +4
Files with missing lines Coverage Δ
pymc/data.py 84.50% <100.00%> (-4.72%) ⬇️
pymc/pytensorf.py 89.66% <0.00%> (-1.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 merged commit 112af3e into pymc-devs:main Feb 10, 2025
25 checks passed
@williambdean williambdean deleted the deprecate-generator branch February 10, 2025 13:15
vandalt pushed a commit to vandalt/pymc that referenced this pull request May 14, 2025
@williambdean @vandalt
Remove deprecated generator data (pymc-devs#7664)
a5a52aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardoV94 ricardoV94 ricardoV94 approved these changes

Assignees

No one assigned

Labels

maintenance major Include in major changes release notes section

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove Python2 generator work around

3 participants

@williambdean @ricardoV94 @nataziel